chore: fix changelog's group variable and properly handle commits newline#441
chore: fix changelog's group variable and properly handle commits newline#441divineniiquaye wants to merge 1 commit intouni-stack:mainfrom
Conversation
📝 WalkthroughWalkthroughThe change refactors changelog group rendering logic in a configuration file by replacing precomputed map-based grouping with per-group filtering within a loop, while also making the output format more compact by removing unnecessary line continuation characters. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/uniwind/cliff.toml`:
- Around line 19-29: The Jinja trim markers ({%- and -%}) around the per-group
loop are removing newlines and collapsing Markdown; update the loop tags so they
do not trim surrounding whitespace (remove the leading/trailing hyphens on the
`{% for commit in group_commits %}`, the `{% if commit.remote.pr_title %}`, the
corresponding `{% endif %}`/`{% endfor %}` tags and the closing `-%}` on the
group block) so newlines are preserved after `### {{ group }}` and after the
last bullet; ensure the block that renders `{{ commit_message | split(pat="\n")
| first | trim }}` remains intact but is wrapped by non-trimming `{% ... %}`
tags to preserve Markdown line breaks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0478151d-6842-42f7-ae10-859898807260
📒 Files selected for processing (1)
packages/uniwind/cliff.toml
|
fixed in #442 |
The changelog.sh produces an error when run, and when you check
CHANGELOG.md, multiple commits under a group newlines are not properly handled.This PR fixes it.
Summary by CodeRabbit