Skip to content

fix: join border radius to fix some components#517

Merged
Brentlok merged 1 commit intomainfrom
join-border-radius
Apr 27, 2026
Merged

fix: join border radius to fix some components#517
Brentlok merged 1 commit intomainfrom
join-border-radius

Conversation

@Brentlok
Copy link
Copy Markdown
Contributor

@Brentlok Brentlok commented Apr 27, 2026

Summary by CodeRabbit

  • Refactor
    • Improved border-radius style processing to automatically consolidate individual corner radius declarations into a single property when all corners share the same value, optimizing style normalization.

@Brentlok Brentlok merged commit 54ce71b into main Apr 27, 2026
1 of 2 checks passed
@Brentlok Brentlok deleted the join-border-radius branch April 27, 2026 06:20
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a45f2b37-4287-4607-af52-08672b694dfe

📥 Commits

Reviewing files that changed from the base of the PR and between 0eaf017 and 6a927a0.

📒 Files selected for processing (1)
  • packages/uniwind/src/metro/processor/rn.ts

📝 Walkthrough

Walkthrough

This PR adds border-radius property consolidation logic to the React Native style normalization processor. When all four individual corner radius properties exist with identical values, the code replaces them with a single borderRadius property; otherwise, it preserves the original styles. A set of border-radius keys is also defined for the validation check.

Changes

Cohort / File(s) Summary
Border-radius property joining
packages/uniwind/src/metro/processor/rn.ts
Added logic to detect when all four corner radius properties have equal values and consolidate them into a single borderRadius shorthand property; includes definition of the border-radius keys set.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 Four corners dancing, all in sync,
Hop together, quick as a blink!
One radius rings true instead of four,
Cleaner styles, what could we ask for? ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch join-border-radius

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

🚀 This pull request is included in v1.6.4. See Release v1.6.4 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant