Parent
docs/issues/unic-archon-dlc/PRD.md
What to build
qa.yaml currently calls merge-pr (which runs the configured tracker's merge CLI command) but does not verify the PR targets the correct base branch first. If the PR was opened against the wrong target — e.g. main instead of develop on a Gitflow project — the merge silently ships to the wrong branch.
Add a verify-pr-base bash node that runs before merge-pr:
- Reads the configured branching strategy from
.archon/unic-dlc.config.json.
- Derives the expected base branch (
develop for Gitflow, main for GitHub Flow).
- For GitHub tracker: calls
gh pr view --json baseRefName and compares.
- For ADO tracker: calls
az repos pr show and compares targetRefName.
- For Jira / local: logs a warning and continues (no CLI to query PR base).
- If the base is wrong: logs a clear error with the expected vs actual branch names and exits non-zero, preventing
merge-pr from running.
This is a YAML-only addition of one bash node with an inline shell snippet — no lib modules or tests are added.
Acceptance criteria
Blocked by
None — can start immediately.
PRD: docs/issues/unic-archon-dlc/PRD.md
Migrated from: docs/issues/unic-archon-dlc/16-qa-verify-pr-base.md (source removed after migration)
Touched by PRs: #39
Parent
docs/issues/unic-archon-dlc/PRD.mdWhat to build
qa.yamlcurrently callsmerge-pr(which runs the configured tracker's merge CLI command) but does not verify the PR targets the correct base branch first. If the PR was opened against the wrong target — e.g.maininstead ofdevelopon a Gitflow project — the merge silently ships to the wrong branch.Add a
verify-pr-basebash node that runs beforemerge-pr:.archon/unic-dlc.config.json.developfor Gitflow,mainfor GitHub Flow).gh pr view --json baseRefNameand compares.az repos pr showand comparestargetRefName.merge-prfrom running.This is a YAML-only addition of one
bashnode with an inline shell snippet — no lib modules or tests are added.Acceptance criteria
qa.yamlhas averify-pr-basebash node withdepends_on: [uat-gate].merge-prhasdepends_on: [verify-pr-base].pnpm checkpasses at repo root after the change.Blocked by
None — can start immediately.
PRD:
docs/issues/unic-archon-dlc/PRD.mdMigrated from:
docs/issues/unic-archon-dlc/16-qa-verify-pr-base.md(source removed after migration)Touched by PRs: #39