[unic-pr-review] Remaining five aspect agents + conditional spawning

[orioltf]

Parent

docs/issues/unic-pr-review/PRD.md

What to build

Add the other five review aspect sub-agents (silent-failure-hunter, type-design-analyzer, pr-test-analyzer, comment-analyzer, code-simplifier) and grow changed-file-analyser.mjs into the full spawn-decision table so each agent only runs when the diff actually touches its concern.

Per ADR-0008: code-reviewer always runs; the others are conditional. Each agent has its own distinctive name + colour, embeds the same Confidence-Score rubric, and emits Findings with the same structured schema as #145.

Clean-slate doctrine. No prompt copying from pr-review-toolkit or apps/claude-code/pr-review/. Each agent's prompt is written fresh against the PRD's "review aspects" guidance.

Acceptance criteria

• agents/silent-failure-hunter.md exists with distinct name + colour, looks for swallowed errors / inappropriate fallback / try-catch antipatterns; spawned when error-handling code changed.
• agents/type-design-analyzer.md exists with distinct name + colour, looks for weakly-encapsulated types and missing invariants; spawned when type definitions changed.
• agents/pr-test-analyzer.md exists with distinct name + colour, looks for test-coverage gaps and missing edge cases; spawned when test files changed.
• agents/comment-analyzer.md exists with distinct name + colour, looks for comment rot / inaccurate docs / over-documentation; spawned when comments or docs changed.
• agents/code-simplifier.md exists with distinct name + colour, looks for opportunities to reduce complexity; spawned when a complexity heuristic fires on any changed file.
• scripts/lib/changed-file-analyser.mjs exports a pure function decideSpawnSet(changedFiles) → Set<string> returning agent names. Table-driven, classifies files by path/extension/diff content.
• tests/changed-file-analyser.test.mjs covers each spawn predicate with at least one positive and one negative fixture.
• A Pre-PR run on a mixed-content diff (code + tests + docs + types) spawns the expected subset of agents (verifiable by orchestrator log).
• All six aspect agents are visually distinguishable in Claude Code's UI (US 44).
• Cross-platform CI green.

Blocked by

• [unic-pr-review] Pre-PR mode skeleton + code-reviewer aspect agent #145

[orioltf]

✅ Issue Resolution Report

PR: #158 (#158)
Status: COMPLETE
Workflow: 70d84536fd313df77c802e42714464e8

---

Summary

All five remaining Review Aspect agents were created and the orchestrator was wired for conditional multi-agent fan-out. Investigation found that the five agent files and decideSpawnSet() already existed — the only missing piece was updating commands/review-pr.md to call the analyser CLI (Step 4a) and fan out to all matched agents in parallel (Step 4b). A post-implementation review pass caught 12 findings; 11 were fixed before merge.

---

Changes Made

File	Action	Description
agents/silent-failure-hunter.md	CREATE	Argus (red) — swallowed errors, empty catch, inappropriate fallbacks
agents/type-design-analyzer.md	CREATE	Euclid (magenta) — wide types, missing invariants, primitive obsession
agents/pr-test-analyzer.md	CREATE	Vesta (green) — test-coverage gaps, weak assertions, missing edge cases
agents/comment-analyzer.md	CREATE	Scribe (yellow) — JSDoc drift, stale TODO/FIXME, over-documentation
agents/code-simplifier.md	CREATE	Occam (blue) — nested conditionals, duplicate logic, .then() chains
scripts/lib/changed-file-analyser.mjs	UPDATE	decideSpawnSet() table + CLI entry (portable pathToFileURL guard, stdin error handler, .tsx extension fix)
tests/changed-file-analyser.test.mjs	UPDATE	30 predicate tests + 10 new CLI/Windows backslash tests (211 total)
commands/review-pr.md	UPDATE	Step 4a (resolve spawn set via CLI) + Step 4b (parallel fan-out) + Step 5 (merge before render)
docs/adr/0008-…	UPDATE	Tense fix + Spawn Table for all 6 agents
CONTEXT.md	UPDATE	Added "Review Aspect" + "Spawn Set" glossary entries
AGENTS.md	UPDATE	Two-part checklist for adding new Review Aspects
README.md	UPDATE	Added review-pr to Commands table; updated Quick Start
agents/*.md (5 files)	UPDATE	Domain-accurate JSON example findings per agent

---

Validation

✅ Type check | ✅ Lint (pnpm ci:check, exit 0) | ✅ Tests (758 passed, 211 in unic-pr-review) | ✅ PR CI (root + 6× OS/Node matrix + CLA)

---

Review & Self-Fix

• 12 review findings from 4 agents (code-review, error-handling, test-coverage, docs-impact)
• 11 fixed: 2 HIGH bugs (Windows CLI guard + missing CLI tests), 8 MEDIUM, 1 LOW
• 10 new tests added
• 8 docs/agent files updated
• 1 MEDIUM skipped (see below)

---

Unaddressed Items

Finding	Severity	Reason
comment-analyzer spawn predicate misses JSDoc rot in .mjs source files	MEDIUM	Extending from doc-files-only to source files may conflict with the intentional ADR-0008 design — needs owner sign-off before widening scope

---

Suggested Follow-up Issues

1. "Align comment-analyzer spawn predicate with JSDoc-in-source use case" (P2) — isDocFile predicate currently misses @param/@returns rot in .mjs source files. Confirm with ADR-0008 owners whether widening to files.some(isDocFile) || files.some(isSourceFile) is desired, then implement + test.

---

Resolved by Archon workflow 70d84536fd313df77c802e42714464e8