[unic-pr-review] Intent gathering via Atlassian (Pre-PR pasted URLs)

[orioltf]

Parent

docs/issues/unic-pr-review/PRD.md

What to build

Wire the Intent Brief into the Pre-PR path. In Pre-PR mode the orchestrator prompts the reviewer for optional Work Item / Confluence URLs (comma-separated; Enter to skip). The Intent Checker sub-agent routes each URL by path (/browse/ → Jira, /wiki/ → Confluence), invokes scripts/atlassian-fetch.mjs to retrieve content, branches Work Items by type (Story → description + ACs; Bug → repro + expected/actual), self-deduplicates across sources, and emits a structured intentCheck block that the summary renderer surfaces at the top of the preview with per-AC verdicts.

Per ADR-0004 (hard-stop) and US 30 (empty intent OK):

• A link that promises intent but is unreachable → hard-stop with a clear message pointing at the relevant setup wizard.
• No links pasted → preview proceeds with the Intent Check block omitted (legitimate state).

Motto: the Intent Checker is a single LLM agent trusted to deduplicate and consolidate across sources — no orchestrator → sub-agents → synthesizer pipeline.

Acceptance criteria

• scripts/atlassian-fetch.mjs exists, uses Node's built-in global fetch (Node 22+), reads credentials via scripts/lib/credentials.mjs (file + env-var override), routes by URL path, fetches Jira issues + Confluence pages via their REST APIs, parses Story vs Bug structure, extracts Confluence page text + linked Confluence URLs from issue bodies.
• agents/intent-checker.md exists with distinct name + colour, receives [{ id, type, url, raw }] plus pasted URLs, calls atlassian-fetch.mjs via Bash, emits a structured Intent Brief plus per-AC verdicts (addressed / partially addressed / unaddressed) — no Bot Signature footer.
• Orchestrator in Pre-PR mode prompts: "Optional Work Item URLs (Jira/ADO Boards) and Confluence URLs, comma-separated. Press Enter to skip." Enter → skip cleanly (US 20).
• Intent Brief is broadcast verbatim as a preamble to every aspect agent in the fan-out batch.
• review-summary-renderer.mjs accepts an optional intentCheck field and renders it between the Notices block and the Severity sections per PRD §10.
• Empty intent: Intent Check section omitted; review otherwise unchanged.
• Hard-stop: when a fetched Work Item promises a Confluence page and the page is unreachable (network or 4xx), the orchestrator aborts with a message naming the URL and the setup command to run. No partial preview emitted.
• tests/atlassian-fetch.test.mjs covers URL routing (Jira vs Confluence), credential resolution (file vs env vars), Story-vs-Bug response parsing, AC extraction, Confluence excerpt extraction, with fetch stubbed.
• Cross-platform CI green.

Blocked by

• [unic-pr-review] Pre-PR mode skeleton + code-reviewer aspect agent #145

[orioltf]

✅ Issue Resolution Report

PR: #159 (#159)
Status: COMPLETE

---

Summary

Issue #147 shipped the Atlassian intent-gathering feature for unic-pr-review Pre-PR mode. The implementation adds URL routing (Jira /browse/ vs Confluence /wiki/), REST fetching with typed FetchError discrimination, ADF text extraction for Stories and Bugs, Confluence HTML-to-text extraction, and a new Intent Checker sub-agent (Ariadne) that synthesises an Intent Brief and per-AC verdicts. All 9 acceptance criteria are satisfied and all 779 workspace tests pass.

---

Changes Made

File	Change
scripts/atlassian-fetch.mjs	NEW — URL routing, Jira/Confluence REST fetch, ADF+HTML extraction, FetchError discriminator, injectable fetch
tests/atlassian-fetch.test.mjs	NEW — 222 test cases covering routing, Story/Bug/Epic/Defect parsing, AC extraction, error classification
agents/intent-checker.md	NEW — Ariadne agent: fetches URLs, synthesises Intent Brief, emits per-AC verdicts
commands/review-pr.md	UPDATED — Added Steps 3.5/3.6 (URL prompt + intent gather); Intent Brief broadcast to aspect agents
scripts/render-summary.mjs	UPDATED — Reads INTENT_CHECK_JSON; renders Intent Check block between Notices and Severity
agents/code-reviewer.md	UPDATED — Treats Intent Brief as authoritative ACs when present
tests/render-summary.test.mjs	UPDATED — 6 new intent-check rendering tests
CHANGELOG.md	UPDATED — Dated entry under [Unreleased]
README.md	UPDATED — Added unic-pr-review to plugins table, install block, corrected docs/ structure

---

Validation

✅ Type check  |  ✅ Lint (Biome + Prettier)  |  ✅ Tests (779 passed, 0 failed)

---

Review & Self-Fix

5 review agents (code-review, error-handling, test-coverage, comment-quality, docs-impact) surfaced 17 findings — 0 CRITICAL, 3 HIGH, 6 MEDIUM, 8 LOW.

• 16 of 17 findings fixed including the relative linkedUrls bug, false hard-stop on internal parser errors, silent parse-error failures, and all documentation gaps
• 11 additional test cases added (233 total in unic-pr-review)
• Fix commit: b81f3f5 — fix(unic-pr-review): address all review findings from PR #159
• Simplify commit: 849fe2c — simplify: reduce complexity in changed files

---

Unaddressed Items

Finding	Severity	Reason
collectIntent non-FetchError else branch is defensive dead code	LOW	Skipped per test-coverage agent recommendation — branch is unreachable through production paths; testing would require artificial injection with no real coverage benefit

---

Suggested Follow-up Issues

No follow-up issues needed — all actionable findings were addressed in the PR.

---

Resolved by Archon workflow a9d5dfb5f5c1d6d5731cdc0c3457c672