Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
56 MADR-lite files across docs/adr/ (24 ADRs) and per-plugin adr/ directories (8 auto-format, 8 pr-review, 12 unic-confluence).
… in tests URL.pathname on Windows returns /D:/a/... which Node interprets as C:\D:\a\... causing MODULE_NOT_FOUND on all Windows CI runs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…version - Use fileURLToPath for sync-version script path (fixes MODULE_NOT_FOUND on Windows) - Add shell:isWindows to git spawnSync (matches pnpm pattern, finds git.cmd in tests) - Normalize PATH key case in test makeTmpDir (avoids duplicate Path/PATH on Windows) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…verify-changelog Production scripts: - tag.mjs: fileURLToPath for sync-version path + shell:isWindows for git tag - verify-changelog.mjs: shell:isWindows for git calls (consistent with bump-version) - verify-changelog.test.mjs: cross-platform PATH key/delimiter in runVerify + add git.cmd ADR factual corrections: - unic-confluence ADR-0001/0002: fix marker syntax (was HTML comments, is [AUTO_INSERT_START:label]) - auto-format ADR-0004: fix config path (.claude-auto-format.json → .claude/unic-format.json) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- docs/adr/README.md: correct backfill date from 2025-05 to 2026-05 - docs/plans/16-adr-backfill.md: fix config filename (.claude-auto-format.json → .claude/unic-format.json) and confluence marker syntax (<!-- confluence:start/end --> → [AUTO_INSERT_START/END: label]) - release-tools: remove shell:isWindows from git spawnSync calls; git.exe is found via PATH/PATHEXT without a shell, avoiding argument escaping issues Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…nv var Add gitCmd() to platform.mjs: returns ['git', ...args] in production and ['node', <shim.cjs>, ...args] when _GIT_BIN is set, avoiding shell:true for git invocations entirely. Replace .cmd-based test shims (which required shell:true on Windows to be found via cmd.exe) with cross-platform Node.js CJS shims that work on all platforms without a shell. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ADRs backfill from Matt Pocock's Grill-me
… with editorconfig
Update Prettier config
Configuration files Jetbrain IDE
…r grilling session
…Code - Detect prior reviews and classify existing threads based on ADO status and diff intersections. - Update handling of iteration IDs to use the latest iteration for diffs and capture prior iteration information. - Modify reply logic to reuse existing threads and post delta summaries instead of creating new ones. - Introduce a test harness with extracted modules for core logic, ensuring no live ADO connection is required for testing. - Update documentation to reflect changes in behavior and new features, including version bump and changelog entries.
…y with thread classification and summary handling
…pts: This is foundational work to establish a common understanding and consistent terminology for all current and future plugins in this repo. The context files include example dialogues to illustrate how the terms should be used in practice.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Oriol Torrent Florensa <oriol.tf@me.com>
…ture documentation
The previous example claimed truncation for a 48-char slug (under the 50-char limit). Replace with the correct full slug and add a genuine truncation example that exceeds 50 chars. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…G.md Aligns prose with CONTEXT.md which marks Ralph/Ralph Orchestrator as tool-specific terms to avoid in favour of the domain term "Spec Runner". The `pnpm ralph` command name and `ralph-orchestrator` package name are kept as literal identifiers. Resolves docs/inbox/replace-ralph-with-spec-runner-in-agents-and-contributing.md Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…DR-0005 Replace the stale four-state vocabulary (Stale/Resolved/Pending/New) with the canonical ADR-0005 terms (addressed/disputed/pending/obsolete). Add the missing `disputed` state, remove `New` (non-Review Threads are excluded before classification, not classified), and tighten the definitions of `obsolete` and `addressed` to match the ADR precisely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-platform Node.js
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Agentic flow updates
…bering Update stale spec number citations in plans 02–07 that referenced pre-renumbering numbers (e.g. "spec 00" for signature instead of "spec 01", self-referential "spec 03" instead of "spec 04" for the diff baseline consumer, etc.). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… (6) classification Add missing byDesign (5) and pending (6) to status-code lists in spec 06 and PRD. In spec 05, explicitly state that ADO pending (status 6) is treated as active — diff-hunk intersection is still required before it is considered addressed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace root docs/adr/0009-… references with the correct plugin-scoped path apps/claude-code/pr-review/docs/adr/0009-… in spec 00 (target behaviour section) and issue 09 (step 6 and acceptance criteria). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…eference Change Status from closed to resolved (closed means PR merged per triage labels). Extend spec range from 00–08 to 00–09 to include the test harness spec. Replace the specific PR number in the smoke-test note with a generic description to comply with the doc's own rule. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fix spec number citations that were missed in the first pass: - spec 01 out-of-scope: detection → spec 02 - spec 02 edge case: partial-run → spec 06 - spec 06 out-of-scope: summary → spec 07 - spec 09 context: feature scope → specs 01–07 - spec 09 classify-thread doc: classification rules → spec 05 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…odes, and metadata - Issue 09: change ADR 0009 creation step to a verification (spec 00 owns creation; avoids duplicate). Similarly scope the prettierignore step to verification only. - Issue 05: align addressed-rule wording with spec 05 — enumerate status codes 2–5 explicitly and note ADO pending (6) needs diff intersection like active. - Spec 09: add commands/review-pr.md and package.json to Touches field. - Spec 03: replace brittle CLAUDE.md line-number reference with a content-based rule identification to survive future line shifts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…PRD addressed rule spec 06 test case: early-exit for no-new-commits belongs to spec 04 (incremental diff), not spec 03 (iteration targeting). PRD addressed rule: enumerate statuses 2–5 explicitly and note that ADO pending (6) requires diff intersection like active, aligning the PRD with spec 05 and issue 05. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
spec 06 also depends on spec 04 (incremental diff baseline provides PRIOR_COMMIT_ID, LATEST_COMMIT_ID, and hunk boundaries). spec 09 depends on specs 02 and 05 in addition to 06, since the test harness extracts modules originally defined in those specs. README table updated to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- spec 02: clarify PRIOR_THREADS vs PRIOR_THREADS_FILE distinction; clarify isSummaryThread as prefix match (heading includes PR title suffix); rephrase timestamp-fallback sentence to make spec 03 ownership explicit. - spec 06: document completion marker ordering — inline replies → delta summary (spec 07) → completion marker. - spec 08: add CLAUDE.md signature-rule update to step 4 (previously unowned); fix marketplace.json path in Touches field. - spec 09: use explicit test file paths instead of a glob in the package.json script to avoid cross-platform globstar issues. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pr-reviews rereviews specs
…criptor typedef and extract runner functions into lib/runners.mjs - Added `FormatterDescriptor` typedef to `lib/types.mjs` for formatter invocation. - Extracted `runFormatter` function into `lib/runners.mjs` with associated tests. - Replaced inline runner functions in `format-hook.mjs` with descriptor constants. - Extracted config loading and defaults into `lib/config.mjs` with tests. - Updated `format-hook.mjs` to utilize the new config module. - Performed version bumps and updated CHANGELOG entries for internal refactors.
…ck was failing) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… table PROMPT.md was capped at specs 00–11; expanded to scan all specs in the README execution order so ralph picks up specs 25–31. README table updated to mark specs 00–22 as done, matching the Status markers already present in the individual spec files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Specs 00, 07, and 08 are all done — drop the dead `npm`/`pnpm bump`/ `verify:changelog` conditional branches. Add cross-platform Node.js API rule and `(vX.Y.Z)` commit suffix to match the root PROMPT.md. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
unic-confluence: drop stale spec-00/spec-19 conditionals, add cross-platform rule, add chore commit type. pr-review: full rewrite — adds Step 1 early-exit check, Deviations handling, conditional Step 4.5 with pnpm bump + verify:changelog, (vX.Y.Z) commit suffix, Questions/Follow-ups instructions, and cross-platform rule. All 9 specs are still pending, so this lands before Ralph touches a single one. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…to all PROMPT.md files Behavioral specs (patch/minor/major) now invoke /tdd with acceptance criteria as the target; structural specs (none) continue direct implementation. Step 4 gains a mandatory pnpm check block. /diagnose is surfaced as a scope-gated supporting skill. ADR-0026 records the dispatch-signal decision. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.