feat(unic-spec-review): shared context (existing comments + Landscape Brief)#223
Closed
orioltf wants to merge 5 commits into
Closed
feat(unic-spec-review): shared context (existing comments + Landscape Brief)#223orioltf wants to merge 5 commits into
orioltf wants to merge 5 commits into
Conversation
…e-detector Extend atlassian-fetch with fetchConfluenceComments (footer + inline via Confluence v1 REST API child/comment endpoint) and mainFetchComments CLI handler. Add landscape-detector producing a LandscapeBrief from repo manifests, root file listing, and user-declared adjacent systems -- stack never hardcoded. Unit tests cover both with injected deps; no live services. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Rename rootEntries → _rootEntries to satisfy Biome noUnusedFunctionParameters. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…typecheck The prior unused-param rename (rootEntries -> _rootEntries) left the JSDoc @param referencing the old name and stripped the inferred type, breaking tsc (TS8024 + TS7006) in CI even though tests passed. Align the JSDoc name to the parameter so it is typed and matched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
|
Closing in favour of a clean re-run of #204: the original workflow's review/self-fix/simplify pipeline was cascade-skipped after a transient verify-pr-base TLS timeout, so this PR never went through those quality steps. Archon can't resume a failed run, so re-triggering from scratch. |
orioltf
deleted the
archon/task-feature-unic-spec-review-204-comments-landscape-br
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atlassian-fetch.mjswithfetchConfluenceComments/mainFetchComments: reads footer and inline Confluence page comments via the v1 REST API child/comment endpoint, read-only with injectedfetch.scripts/lib/landscape-detector.mjs:detectLandscapeproduces aLandscapeBrief(stack, testSetup, tooling, reachableProd, adjacentSystems) from repo manifests and root file listing; stack never hardcoded; injectable deps for tests.detectLandscape. Total: 137 tests, 0 failures.Why
S3 of the unic-spec-review plugin (issue #204). Gives review agents shared context computed once per run: prior discussion on the spec page (comments) and the project detected tech landscape (Brief).
Test plan
pnpm --filter unic-spec-review test-- 137 pass, 0 failpnpm --filter unic-spec-review typecheck-- cleanverify:changelogpasses (bumped to 0.1.3 with dated entry)Closes #204
Generated with Claude Code