-
Notifications
You must be signed in to change notification settings - Fork 5
Upgrade Lume #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Lume #49
Conversation
eemeli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including the formatting changes seems rather unrelated to a dependency update. That should probably be done in a separate PR, if it's required at all.
|
@eemeli Fair enough |
|
I don't have write access or a good understanding of the stack used here, so this probably needs a review from @lucacasonato rather than me. |
srl295
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the stack but
- changes seem reasonable and
- it builds and works
@lucacasonato any objection? Otherwise we're a bit stuck because main fails to build.
|
Looks good, need to bring back the animation again tho. It should not be too difficult, I can take a look tomorrow. |
lucacasonato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @oscarotero!
|
I was unable to push to your branch with a fix for the animation, so I've pushed it to a new PR instead: #54. Your author attribution remains in there. |
|
No problem. Thanks @lucacasonato ! |
This PR upgrades Lume to the last version.
@applyinside@keywords(specificallypulse-bg-blue). So I removed this animation. Probably you know how to bring it back.Most changes are caused by theedit: I reverted this change for claritydeno fmtcommand.