Skip to content

Conversation

@adrg
Copy link
Collaborator

@adrg adrg commented Sep 2, 2019

Related to #145


This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #162 into development will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #162      +/-   ##
===============================================
- Coverage        63.54%   63.45%   -0.09%     
===============================================
  Files              189      189              
  Lines            34417    34414       -3     
===============================================
- Hits             21871    21839      -32     
- Misses           12029    12067      +38     
+ Partials           517      508       -9
Impacted Files Coverage Δ
model/image.go 74.26% <0%> (-6.5%) ⬇️
internal/jbig2/bitmap/bitmap.go 81.03% <0%> (-2.59%) ⬇️
core/encoding.go 57.38% <0%> (-0.88%) ⬇️
model/colorspace.go 32.63% <0%> (ø) ⬆️
extractor/text.go 72.55% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e81d3...5c881d6. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. A few comments.

Copy link
Collaborator Author

@adrg adrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on @gunnsth)


.travis/build_examples.sh, line 12 at r1 (raw file):

Previously, gunnsth (Gunnsteinn Hall) wrote…

I noticed in the build output there was:

$ ./.travis/build_examples.sh
Cloning into '/home/travis/gopath/src/github.com/unidoc/unipdf-examples'...
remote: Enumerating objects: 52, done.
remote: Counting objects: 100% (52/52), done.
remote: Compressing objects: 100% (44/44), done.
Receiving objects:  63% (remote: Total 928 (delta 16), reused 27 (delta 8), pack-reused 876
Receiving objects: 100% (928/928), 3.88 MiB | 14.76 MiB/s, done.
Resolving deltas: 100% (601/601), done.
Already on 'v3'
Your branch is up to date with 'origin/v3'.
Building to bin/ folder
go: finding github.com/youtube/vitess v2.1.1+incompatible
go: finding github.com/wcharczuk/go-chart v2.0.1+incompatible
go: finding github.com/miekg/pkcs11 v1.0.2
go: finding github.com/golang/freetype v0.0.0-20170609003504-e2365dfdc4a0
go: finding github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: finding github.com/blend/go-sdk v2.0.0+incompatible
go: finding github.com/ThalesIgnite/crypto11 v0.1.0
go: finding github.com/unidoc/unipdf/v3 v3.1.1
go: downloading github.com/unidoc/unipdf/v3 v3.1.1
...

which indicates it was downloading the unipdf from the go.mod file.

It might be necessary to add a replace directive to the go.mod file, something like

replace github.com/unidoc/unipdf/v3 => /path/to/github.com/unidoc/unipdf

This can also be added with the go command line tool (see go help mod edit).

Done.

@gunnsth gunnsth merged commit 7406957 into unidoc:development Sep 3, 2019
@adrg adrg deleted the travis-ci branch September 6, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants