Merged
Conversation
Signed-off-by: Justin Chadwell <justin@unikraft.com>
This makes it clearer where args were split, and how they were split. Signed-off-by: Justin Chadwell <justin@unikraft.com>
Signed-off-by: Justin Chadwell <justin@unikraft.com>
craciunoiuc
reviewed
Apr 21, 2026
Member
craciunoiuc
left a comment
craciunoiuc
left a comment
There was a problem hiding this comment.
Just one request my side 🥹
Signed-off-by: Justin Chadwell <justin@unikraft.com>
jedevc
force-pushed
the
jedevc/arg-splitting
branch
from
56ff5da to
5238225
Compare
craciunoiuc
approved these changes
Apr 21, 2026
Member
craciunoiuc
left a comment
craciunoiuc
left a comment
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.com
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/unikraft/issue/TOOL-682/split-instance-args-in-cli.
When specified something like
--args "echo foo", this splits it into["echo", "foo"]. However, I noticed that this rendered weirdly, so updated the array-like rendering to use JSON-like formatting instead of CSV formatting, and updated the parser to support this as well, so we keep some level of consistency.