feat: Use explicit kraftfile type if specified#290
Merged
Conversation
craciunoiuc
reviewed
Apr 23, 2026
| kraftfile.SourceTypeErofs: kraftfile.FsTypeErofs, | ||
| } | ||
| if exp, ok := expected[opts.Rootfs.Type]; ok && opts.Rootfs.Format != exp { | ||
| // TODO: maybe we could be smart and convert this |
Member
There was a problem hiding this comment.
Theoretically we have readers/writes for them, so this means we could covert them. right? 👀
craciunoiuc
approved these changes
Apr 23, 2026
Member
craciunoiuc
left a comment
craciunoiuc
left a comment
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.com
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.com
Member
|
Static check failed :((( |
No need to do source type detection if the kraftfile has an explicit `type` - we should just use that. Additionally, this adds some more tests to check that all the rootfs builds produce reasonable results. Signed-off-by: Justin Chadwell <justin@unikraft.com>
jedevc
force-pushed
the
jedevc/rootfs-build-use-type
branch
from
2312812 to
ab4b9e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #245 (comment)
No need to do source type detection if the kraftfile has an explicit
type- we should just use that.Additionally, this adds some more tests to check that all the rootfs builds produce reasonable results.