feat: Add rom support#303
Merged
Merged
Conversation
jedevc
force-pushed
the
jedevc/roms
branch
2 times, most recently
from
fe4f647 to
cf07ac2
Compare
Member
Author
|
Grrr, copilot is right, I will look at this later 😠 |
craciunoiuc
requested changes
May 7, 2026
We should have been showing these the whole time! They're real fields! Signed-off-by: Justin Chadwell <justin@unikraft.com>
Allowing both building and creating instances with mounted ROMs. Note, this does contain breaking changes - previously, doing `--set services=service1,service2` would work. However, now, this must be split into `--set services=service1 --set services=service2`. This means we can now have comma separated values in the ROM values themselves. Signed-off-by: Justin Chadwell <justin@unikraft.com>
craciunoiuc
approved these changes
May 8, 2026
Member
craciunoiuc
left a comment
craciunoiuc
left a comment
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing both building and creating instances with mounted ROMs.
Fixes https://linear.app/unikraft/issue/TOOL-695/rom-support-in-cli.
TODO:
file=./path/to/fileor something for mounting in files.