feat(docs): union ibc spec #3201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
hussein-aitlahcen
had a problem deploying
to
docs-preview
GitHub Actions
Error
hussein-aitlahcen
force-pushed
the
union-ibc-spec
branch
from
8d7e891 to
1304a23
Compare
hussein-aitlahcen
temporarily deployed
to
docs-preview
GitHub Actions
Inactive
Docs 🤌✨ Deployment complete! Take a peek over at https://8a75bd2f.docs-ajn.pages.dev |
hussein-aitlahcen
force-pushed
the
union-ibc-spec
branch
from
1304a23 to
bee0ff4
Compare
hussein-aitlahcen
temporarily deployed
to
docs-preview
GitHub Actions
Inactive
aeryz
reviewed
Nov 4, 2024
Contributor
aeryz
left a comment
aeryz
left a comment
There was a problem hiding this comment.
We also changed recvPacket to get multiple packets instead of one.
hussein-aitlahcen
force-pushed
the
union-ibc-spec
branch
from
bee0ff4 to
82585ab
Compare
hussein-aitlahcen
temporarily deployed
to
docs-preview
GitHub Actions
Inactive
hussein-aitlahcen
force-pushed
the
union-ibc-spec
branch
from
82585ab to
899e1de
Compare
hussein-aitlahcen
had a problem deploying
to
docs-preview
GitHub Actions
Error
hussein-aitlahcen
force-pushed
the
union-ibc-spec
branch
from
899e1de to
ec32143
Compare
hussein-aitlahcen
temporarily deployed
to
docs-preview
GitHub Actions
Inactive
benluelo
reviewed
Nov 5, 2024
|
|
||
| - [`connectionId`](https://github.com/cosmos/ibc/tree/41a8caa54d8691b7fa98795d31f401e1df31e18c/spec/core/ics-003-connection-semantics#identifier-validation) is no longer a string but a unique `uint32`. | ||
| - [`ConnectionEnd`](https://github.com/cosmos/ibc/tree/41a8caa54d8691b7fa98795d31f401e1df31e18c/spec/core/ics-003-connection-semantics#data-structures) | ||
| - `counterpartyPrefix` has been removed. |
Contributor
There was a problem hiding this comment.
Perhaps explain that this is to be done in the light client now?
| - [`Packet`](https://github.com/cosmos/ibc/blob/41a8caa54d8691b7fa98795d31f401e1df31e18c/spec/core/ics-004-channel-and-packet-semantics/README.md#definitions) | ||
| - `sourcePort` has been removed. | ||
| - `destinationPort` has been removed. | ||
| - `timeoutHeight` type has been changed from `(uint64, uint64)` to `uint64`. |
Contributor
There was a problem hiding this comment.
Explain that revision number is removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.