Skip to content

Conversation

@benluelo
Copy link
Contributor

@benluelo benluelo commented Apr 18, 2025

  • use dep = { workspace = true } instead of dep.workspace = true and reformatted some Cargo.toml files to be more consistent with the style used throughout the repo
  • move some more deps to workspace deps
  • remove dead voyager plugin data.rs/callback.rs files and use Never instead
  • remove some unused deps from some crates with cargo-machete and unused_crate_dependencies
    • note that both are imperfect and have many false positives/negatives, so i only ran it manually locally and did not make a CI check for this

leaner deps means we get faster build times and better caching in CI, as packages depend on a smaller portion of the lockfile. more improvements can be made here (aside from just removing deps), but this is a good start.

@vercel
Copy link

vercel bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
site ⬜️ Ignored (Inspect) Visit Preview Apr 21, 2025 1:57pm

@benluelo benluelo merged commit 9641c22 into main Apr 21, 2025
104 checks passed
@benluelo benluelo deleted the machete branch April 21, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants