Skip to content

feat(app2): add client-side GQL caching with TTL #4609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehegnes merged 5 commits into from
May 26, 2025
Merged

feat(app2): add client-side GQL caching with TTL #4609

ehegnes merged 5 commits into from
May 26, 2025

Conversation

@ehegnes
Copy link
Contributor

@ehegnes ehegnes commented May 24, 2025 •
edited
Loading

  • Provision tagged error for GraphQL promise rejections. (currently an "unknown exception")
  • Make GraphQL an invertible Effect dependency.
    • Add initial approach for mocking GQL with schema usage. Will require additional changes to be viable.
  • Add GQL caching with TTL based on custom @cached directive from given document definition.
  • Dependency upgrades for Effect family.

ehegnes added 2 commits May 24, 2025 13:33
@ehegnes
feat(app2): add client-side GQL caching with TTL
e2a9257 
Signed-off-by: Eric Hegnes <eric@hegnes.com>
@ehegnes
fix(app2): runtime typings for GQL
25f9e81 
Signed-off-by: Eric Hegnes <eric@hegnes.com>
@ehegnes ehegnes requested review from Swepool and cor May 24, 2025 17:34
@vercel
Copy link

vercel bot commented May 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
site ⬜️ Ignored (Inspect) Visit Preview May 26, 2025 4:56pm

@github-actions
Copy link

github-actions bot commented May 24, 2025 •
edited
Loading

App 2 🤌

✨ Deployment complete! Take a peek over at https://dbd85489.app2-9yo.pages.dev
✨ Deployment alias URL: https://head.app2-9yo.pages.dev

@ehegnes
chore(app2): nix fmt
032ad65 
Signed-off-by: Eric Hegnes <eric@hegnes.com>
ehegnes
ehegnes commented May 24, 2025
View reviewed changes
@ehegnes
fix(app2): make GQL TTL derive min in doc
5003367 
Signed-off-by: Eric Hegnes <eric@hegnes.com>
@ehegnes
Copy link
Contributor Author

ehegnes commented May 25, 2025

This service should arguably move into the SDK, but a strategy for dependency inversion of the GraphQL URL is required, and migrating all app GQL usage to SDK is out-of-scope.

@ehegnes
fix(app2): cache with local storage not session
fa570cb 
Signed-off-by: Eric Hegnes <eric@hegnes.com>
@ehegnes ehegnes merged commit 53ead4c into main May 26, 2025
115 checks passed
@ehegnes ehegnes deleted the app-gql-cache branch May 26, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cor cor cor approved these changes

@Swepool Swepool Awaiting requested review from Swepool Swepool is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ehegnes @cor