Add *no broken windows* #9
Conversation
smara-codes
requested review from
VitaliiGavadzyn,
andriytam,
cshlatz,
cwollensak,
fran-grav,
lboright,
levijackson,
tderenko,
toddlamothe,
vasyldutchak and
yuriy-chabaniuk
There was a problem hiding this comment.
Approve! I like this rule very much and think it's very important. A good example of our broken windows in ezpublish are conditions like if site_id = <id> or if feed_id = <feed_id>.
I think it's very important not to break them in v2 of platform or any other new project we start, while I'm OK with them in ezpublish, when it start to take too much time to address them.
Both articles refers to bad designs, wrong decisions, or poor code as for explanation to broken windows. I think it worth having them listed here as well.
fran-grav
left a comment
fran-grav
left a comment
There was a problem hiding this comment.
100% agree. There may be times when we have to agree on the definition of a broken window.
toddlamothe
left a comment
toddlamothe
left a comment
There was a problem hiding this comment.
I love this principle, and it is well written.
vasyldutchak
left a comment
vasyldutchak
left a comment
There was a problem hiding this comment.
Good articles and important principles.
|
@smaraf do we wait for everyone to approve before merging? |
|
@toddlamothe I was giving folks more time to review it but I think we have enough approvals so I'll merge |
No description provided.