Draft
Conversation
- Also adapts python versions (floor is now 3.11 for Django 5.2 and 3.12 for Django 6). - Lowers coverage to 97%. Should be addressed in a distinct PR. - Updates all dependencies. - Enforces linting: Removing unused imports, removing unused variables, fix line length.
Run uv run tox -r
uv run tox -r
shell: /usr/bin/bash -e {0}
env:
UV_FROZEN: 1
UV_CACHE_DIR: /home/runner/work/_temp/setup-uv-cache
MREG_DB_PASSWORD: postgres
python312-django52: venv> .venv/bin/uv venv -p /home/runner/work/mreg/mreg/.venv/bin/python --allow-existing --python-preference system .tox/python312-django52
python312-django52: uv-sync> uv sync --locked --python-preference system --no-default-groups --group ci --group dev -p /home/runner/work/mreg/mreg/.venv/bin/python
error: the argument '--locked' cannot be used with '--frozen'
Usage: uv sync --locked --no-default-groups --group <GROUP> --python <PYTHON> --cache-dir <CACHE_DIR>
For more information, try '--help'.
python312-django52: exit 2 (0.01 seconds) /home/runner/work/mreg/mreg> uv sync --locked --python-preference system --no-default-groups --group ci --group dev -p /home/runner/work/mreg/mreg/.venv/bin/python pid=3242
python312-django52: FAIL ✖ in 0.09 seconds
python312-django60: venv> .venv/bin/uv venv -p /home/runner/work/mreg/mreg/.venv/bin/python --allow-existing --python-preference system .tox/python312-django60
python312-django60: uv-sync> uv sync --locked --python-preference system --no-default-groups --group ci --group dev -p /home/runner/work/mreg/mreg/.venv/bin/python
error: the argument '--locked' cannot be used with '--frozen'
Usage: uv sync --locked --no-default-groups --group <GROUP> --python <PYTHON> --cache-dir <CACHE_DIR>
For more information, try '--help'.
python312-django60: exit 2 (0.01 seconds) /home/runner/work/mreg/mreg> uv sync --locked --python-preference system --no-default-groups --group ci --group dev -p /home/runner/work/mreg/mreg/.venv/bin/python pid=3250
python312-django52: FAIL code 2 (0.09 seconds)
python312-django60: FAIL code 2 (0.05 seconds)
evaluation failed :( (0.18 seconds)
With the move to a newer Django, we can finally use the built-in support for parallel testing. The effect is rather profound: ``` $ source .venv/bin/activate && source .env && coverage run manage.py test --parallel Found 884 test(s). Creating test database for alias 'default'... Cloning test database for alias 'default'... Cloning test database for alias 'default'... Cloning test database for alias 'default'... Cloning test database for alias 'default'... Cloning test database for alias 'default'... Cloning test database for alias 'default'... Cloning test database for alias 'default'... Cloning test database for alias 'default'... Cloning test database for alias 'default'... Cloning test database for alias 'default'... System check identified no issues (0 silenced). .....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................s.............................................................................................................................................................................................................................................................................................................................................s................................................................ ---------------------------------------------------------------------- Ran 884 tests in 54.608s OK (skipped=2) Destroying test database for alias 'default'... Destroying test database for alias 'default'... Destroying test database for alias 'default'... Destroying test database for alias 'default'... Destroying test database for alias 'default'... Destroying test database for alias 'default'... Destroying test database for alias 'default'... Destroying test database for alias 'default'... Destroying test database for alias 'default'... Destroying test database for alias 'default'... Destroying test database for alias 'default'... ```
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage work after the last set of major changes.