[Spark] Enable credScopedFs by default in Spark connector#1479
Open
openinx wants to merge 4 commits into
Open
Conversation
Signed-off-by: Zheng Hu <openinx@gmail.com>
…ault Signed-off-by: Zheng Hu <openinx@gmail.com>
Signed-off-by: Zheng Hu <openinx@gmail.com>
openinx
commented
Apr 7, 2026
| return createSparkSessionWithCatalogs(false, false, catalogs); | ||
| } | ||
|
|
||
| protected SparkSession createSparkSessionWithCatalogs(boolean renewCred, String... catalogs) { |
Collaborator
Author
There was a problem hiding this comment.
This method actually is unused any more, so we should be safe to remove it.
openinx
changed the title
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Enable
credScopedFs.enabledby default in the Spark connector (DEFAULT_CRED_SCOPED_FS_ENABLED = true). Previously users had to explicitly setcredScopedFs.enabled=truein their catalog options to opt in. Since the credential-scoped filesystem provides better credential isolation and security, it should be the default behavior going forward. Users who need the old behavior can still opt out by settingcredScopedFs.enabled=false.Also updates
BaseSparkIntegrationTesthelper overloads to default tocredScopedFsEnabled=true, so non-parameterized tests exercise the new default. The parameterized tests already cover bothfalseandtruecombinations explicitly.