Skip to content

Add support for Variant type to unitycatalog AI#889

Merged
BenWilson2 merged 9 commits intounitycatalog:mainfrom
BenWilson2:ai-variant
Feb 10, 2025
Merged

Add support for Variant type to unitycatalog AI#889
BenWilson2 merged 9 commits intounitycatalog:mainfrom
BenWilson2:ai-variant

Conversation

@BenWilson2
Copy link
Copy Markdown
Collaborator

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

Adds support for passing SQL VARIANT types for function definitions, mapping to a custom Python type class instance for conversion purposes.

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Copy link
Copy Markdown
Collaborator

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation LGTM! Let's make sure integration test passes on our runner :D

Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
@BenWilson2
Copy link
Copy Markdown
Collaborator Author

@BenWilson2 BenWilson2 merged commit 14c75d6 into unitycatalog:main Feb 10, 2025
@BenWilson2 BenWilson2 deleted the ai-variant branch February 10, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants