chore: replace isort and flake8 with ruff#56
Merged
corp-0 merged 4 commits intounitystation:developfrom Jun 17, 2023
Merged
Conversation
Chore
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
corp-0
reviewed
Jun 4, 2023
Member
|
Did you test if the app was running? |
Contributor
Author
|
I did not test this because project has 0 docs on how to run it |
Member
|
To run the app you do the usual. Make a .env file, the values on example.env should be perfectly fine for running locally. You then docker compose up the dev-compose file. |
Member
|
tested locally and this works fine. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruff runs at 8 times faster on this project than isort + flake8 while performing more checks (387ms v 47ms).
It seems like imports were not sorted properly and poetry config for dev dependencies was broken, i fixed that (though unsure about huge .lock file changes, i do not use poetry myself), as well as fixing a few other lints like module name
central-command -> central_command, line lengths etc.Overall this is pretty strict config with lots of rules, these can be relaxed if needed. Currently all checks pass.
Also bumped max line length from 88 to 121