re #96 delete level-6 baseline; document the 11 residual exceptions#112
Merged
Conversation
…ptions The level-6 baseline is now empty and removed. The 11 findings that cannot be fixed at root cause within src-only analysis are converted to documented ignoreErrors (grouped, with rationale), in the same spirit as the ext-* stubs: - trait.unused (8): public-API mixin traits (Data entity traits, LogMessage, EventStack, TagsAware) consumed by host apps and exercised by test fixtures; PHPStan analyses src only, so it reports them as used zero times. - missingType.generics (2): CookieCollection/SetCookieCollection intentionally diverge from Map<string, Cookie> (values() returns string cookie values), so no @extends binding is Liskov-valid. - argument.templateType (1): Cycle ORM getRepository()'s class-string<T>| non-empty-string|T union blocks template inference; result pinned via @var. Level 6 reached with no baseline file (only documented ignoreErrors remain).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the level-6 milestone of #96: the baseline file is deleted and PHPStan runs clean at level 6 with an empty baseline.
The 11 findings that cannot be fixed at root cause within
src-only analysis are converted into documentedignoreErrors(grouped, each with rationale) — the same kind of justified, tool/design-limitation exception as the existing ext-* stubs:trait.unused(8) — public-API mixin traits (theDataentity traits,LogMessageTrait,EventStackAwareTrait,TagsAwareTrait) consumed by host applications and exercised by the framework's own test fixtures. PHPStan analysessrconly, so it reports them as used zero times. (Addingtests/to paths surfaces 1006 test-code findings — out of scope.)missingType.generics(2) —CookieCollection/SetCookieCollectionintentionally diverge fromMap<string, Cookie>(values()returns string cookie values, notCookieobjects), so no@extendsbinding is Liskov-valid without a compose-vs-extend refactor.argument.templateType(1) — Cycle ORM'sgetRepository()parameter isclass-string<T>|non-empty-string|T, an ambiguous union that blocks template inference; the concrete result is pinned via@var CycleNativeRepository<TEntity>.Test plan
composer stan(PHPStan 2.1, no baseline) —[OK] No errors