docs: sync AGENT.md §7 modernization status with reality#98
Merged
Conversation
The roadmap marked Phase 2 and several Phase 3d/4 items "PENDING" when they're actually done — misleading future sessions. Corrected: - Phase 2 (Rector): COMPLETE — rector --dry-run green on master, runs in CI static-analysis (not composer qa). Notes the armed ExplicitNullableParamTypeRector (#93) and the deliberate NewInInitializerRector skip (BC: contract-narrowing). - Phase 3d: MOSTLY COMPLETE — readonly (148) + enums (8) + PHPDoc-type cleanup done; only PSR-14 for Altair\Happen remains → tracked in #97. - Phase 4: IN PROGRESS — PHPStan at level 6 with baseline (#95), burn-down + 6→8 tracked in #96; PHPUnit attribute migration done (only the intentional legacy-@Covers fixture remains). Doc-only; no code paths touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The roadmap in AGENT.md §7 had drifted — it marked Phase 2 and several Phase 3d/4 items "PENDING" when they're actually done. A fresh session reading it (as I did) gets misled about what's left. This corrects it.
Changes
rector --dry-runis green on master and runs in CI'sstatic-analysisjob (flagged that it's not incomposer qa, so run it before pushing). Documents the armedExplicitNullableParamTypeRector(Fix PHP 8.4 implicit-nullable parameter deprecations (Rector php84 set) #93) and the deliberateNewInInitializerRectorskip (a contract-narrowing BC change we declined).readonly(148 classes) + enums (8) + PHPDoc-type cleanup are done; onlyAltair\HappenPSR-14 remains → tracked in Implement PSR-14 dispatch in Altair\Happen (object-based, alongside name-based API) #97.@coversfixture remains).Why
Same traceability concern that prompted #93/#96/#97 — the canonical guide should match the tracker so the next session can find the real remaining work instead of re-discovering it.
Doc-only; no code paths touched (CI gates analyse
src/, so they're unaffected).