Default to dom-context's provider using an element, allow customization of the element tag, and add an option to disable it.#561
Merged
NullVoxPopuli merged 4 commits intoNov 21, 2025
Conversation
|
|
Contributor
|
…er, and it's not safe to do so otherwise
NullVoxPopuli
force-pushed
the
nvp/dom-context-must-have-an-element-for-the-provider
branch
from
0e9c854 to
ab169f8
Compare
NullVoxPopuli
changed the title
NullVoxPopuli
deleted the
nvp/dom-context-must-have-an-element-for-the-provider
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not always safe to have the provider be element-less.
See this repro.
I've flipped the Provider component back to using an element for now, but added an argument to the
Providercomponent (@element={{false}}) to allow the non-element behavior.