Move menu toggle to the items#600
Merged
Merged
Conversation
|
|
NullVoxPopuli
approved these changes
Dec 18, 2025
Contributor
NullVoxPopuli
left a comment
NullVoxPopuli
left a comment
There was a problem hiding this comment.
Approach looks good!
Are there existing tests around this behavior?
Contributor
Author
Good call. I don't think there's a test that currently verifies clicking on an item closes the menu. I can add one. I'm not sure how to test the |
Contributor
|
LinkItem can have |
barryofguilder
force-pushed
the
jb/menu-link
branch
2 times, most recently
from
e58a0ed to
2c2614b
Compare
barryofguilder
force-pushed
the
jb/menu-link
branch
from
2c2614b to
fab0362
Compare
NullVoxPopuli
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have a
Menuthats fixed in your app and then you click aLinkItemto navigate to another route in your app, the menu content will still be displaying. This is because it seems that the click event on the link isn't bubbling up to theContentcomponent's click handler.This moves the
toggleclick handler to theItemandLinkItemcomponents of aMenurather than on theContentcomponent. This way, clicking on aLinkItemwill always fire the toggle of the menu.This fixes #591