Create standalone Separator component with @as argument for dynamic element tags#637
Conversation
|
|
|
@copilot make a separate |
Done! Created a standalone
|
|
@copilot because the Separator can be used in lists, it should have an Also, the Breadcrumb component should wire up as to be |
Done in commit 093f4da:
|
| {{#let (hash Separator=(component Separator as="li")) as |b|}} | ||
| <nav aria-label={{if @label @label "Breadcrumb"}} ...attributes> | ||
| <ol> | ||
| {{yield b}} |
There was a problem hiding this comment.
@copilot don't use let like you have, just yield the thing like how it was before
There was a problem hiding this comment.
Fixed in commit 6652df1. Removed the {{#let}} block and now yielding the hash directly like other components in the codebase (e.g., toggle-group).
…rposes Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
6652df1 to
6a48275
Compare
|
…and remove unnecessary style adjustments
Implementation Plan for Issue #636
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.