Remove manifest-fetching script from test HTML#669
Merged
Conversation
|
|
Merged
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Re-enable accessibility testing
Remove manifest-fetching script from test HTML
Feb 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were crashing before any assertions ran with
Global error: Script error. at , line 0in Chrome. The culprit was a<script type="module">intests/index.htmlthatfetch-ed/kolay-manifest/manifest.json— an endpoint served virtually by the kolay Vite plugin in dev mode only, absent from the builtdist/directory that testem serves.Changes
docs-app/tests/index.html— Remove the script block that fetched/kolay-manifest/manifest.jsonand setwindow.__pages__:window.__pages__was already unused; the test had been updated to retrieve pages viadocsManager(this)inside the test bodywindow.Bufferstub also contained in that block is already provided byapp/app.ts🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.