Fix missing @package in CommentQuery causing a11y test failures#670
Merged
Conversation
|
|
Merged
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Re-enable a11y testing
Fix missing @package in CommentQuery causing a11y test failures
Feb 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The a11y page-crawl test was failing with an unrecoverable render error ("A @Package must be specified to load.") when visiting
/6-utils/shadowed.md, becauseCommentQueryfromkolaywas called without the required@packagearg.Changes
docs-app/app/templates/6-utils/shadowed.gjs.md: Added@package="ember-primitives"to<CommentQuery>and corrected the module path todeclarations/components/shadowed(consistent with other pages likescroller.gjs.md)The
Loadcomponent insideCommentQuerythrows synchronously when@packageis falsy, which put Ember's renderer into an unrecoverable error loop for every subsequent re-render (e.g. on color scheme toggle), ultimately failing the test.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.