Fix injected deps sync when turbo replays cached builds#703
Merged
NullVoxPopuli merged 1 commit intoApr 5, 2026
Merged
Conversation
Two issues caused the deploy preview docs-app build to fail with: Rollup failed to resolve import "ember-primitives/on-resize" 1. The //#sync turbo task was cached, so the root sync script was replayed from cache logs instead of re-executed after builds. Fix: add "cache": false to //#sync. 2. The sync scripts in docs-app and test-app were no-op echo stubs, relying on pnpm's sync-injected-deps-after-scripts hook. But that hook only fires when pnpm itself runs the build script — not when turbo restores outputs from cache. Fix: change sync scripts to run pnpm install --frozen-lockfile, which re-syncs injected deps. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
NullVoxPopuli
approved these changes
Apr 5, 2026
Merged
NullVoxPopuli-ai-agent
pushed a commit
to NullVoxPopuli-ai-agent/ember-primitives
that referenced
this pull request
Apr 5, 2026
The previous fix (universal-ember#703) put pnpm install --frozen-lockfile in the sync scripts and made //#sync uncached. But //#sync runs before ember-primitives:build (it has no dependsOn), so the injected deps were synced before dist/ existed — same failure. The correct place is _syncPnpm, which turbo already configures with dependsOn: ["^build"] and cache: false. This ensures the sync runs after upstream builds complete (dist/ exists) and before downstream consumers (docs-app:build:dev). Changes: - Add _syncPnpm script to docs-app and test-app: pnpm install --frozen-lockfile - Restore sync scripts to their original echo stubs - Restore //#sync to cacheable (it just runs the echo stubs, no need to bust cache) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deploy Preview fails on
mainwith:Root cause
ember-mobile-menuresolvesember-primitivesthrough the pnpm store's injected workspace copy. When turbo replaysember-primitives:buildfrom cache, thedist/files are restored toember-primitives/dist/but the injected copy in the pnpm store is never updated — two things prevent it://#syncis cached by turbo — the root sync task has no"cache": false, so turbo replays cached logs instead of re-executingsync-injected-deps-after-scripts[]=buildhook. But that hook only fires when pnpm runs the build script — not when turbo restores outputs from cacheFix
"cache": falseto//#syncin turbo.jsonpnpm install --frozen-lockfilewhich re-syncs injected depsTest plan
Once merged,
workflow_dispatchthe Deploy Preview targeting PR #699 to verify docs-app builds.🤖 Generated with Claude Code