Fix deploy preview workflow_dispatch by resolving PR info upfront#705
Merged
NullVoxPopuli merged 1 commit intoApr 5, 2026
Conversation
The deploy preview workflow uses workflow_run context for branch name, repo, and PR number — but these are all empty for workflow_dispatch triggers, causing: - Empty ref on checkout (defaults to main instead of PR branch) - Empty --branch on Cloudflare deploy (wrangler fails) - Missing PR number on sticky comment Fix by centralizing PR info resolution in determinePR: - For workflow_dispatch: look up branch/repo from the PR number input via gh pr view - For workflow_run: use the existing workflow_run context - Pass branch, repo, and number as job outputs consumed by all downstream jobs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
NullVoxPopuli
approved these changes
Apr 5, 2026
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The deploy preview workflow uses
github.event.workflow_runcontext for branch name, repo, and PR number — but these are all empty forworkflow_dispatchtriggers, causing:refon checkout → buildsmaininstead of the PR branch--branchon Cloudflare deploy → wrangler crashesFix
Centralize PR info resolution in
determinePR. Forworkflow_dispatch, usegh pr viewto look up the branch and repo from the PR number input. Passbranch,repo, andnumberas job outputs consumed by Build, Deploy, and PostComment.Test plan
workflow_dispatchwith PR number → checks out correct branch, deploys, posts commentworkflow_runfrom CI → same behavior as before (uses workflow_run context)🤖 Generated with Claude Code