Fix Deploy: Production wrangler install failure#720
Merged
NullVoxPopuli merged 1 commit intoApr 6, 2026
Merged
Conversation
|
|
Contributor
|
The wrangler-action detects pnpm from the lockfile and runs `pnpm add wrangler` which fails in a workspace without `-w`. By separating the build (with repo checkout) from the deploy (artifact-only, no checkout), the deploy job has no lockfile present so wrangler-action falls back to npm — matching the existing deploy-preview pattern. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fb59f7d to
6350326
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeployProductioninto separateBuildProductionandDeployProductionjobspnpm-lock.yaml, so wrangler-action falls back tonpm(matching the existing deploy-preview pattern)Problem
cloudflare/wrangler-action@v3detects pnpm from the lockfile and runspnpm add wrangler, which fails in a workspace withERR_PNPM_ADDING_TO_ROOT(requires-wflag the action doesn't pass).Test plan
🤖 Generated with Claude Code