getPromiseState#154
Merged
NullVoxPopuli merged 13 commits intomainfrom Jul 19, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@NullVoxPopuli out of curiosity, is this basically the same utility https://github.com/tracked-tools/ember-async-data provides? |
Contributor
Author
|
It's similar but not quite -- step next is to remove ember-async-data from reactiveweb. ember-async-data has a lot of unneeded checks, and doesn't properly handle already-resolved promises. getPromiseState should, on average, give you faster applications due to not needing to always wait another render cycle to get you the resolved values. ember-async-data's desire to hard-error when accessing certain properties at different times of the promise lifecycle has also bothered me for a very long time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.