Skip to content

Fix docs site: kolay src shorthand is not implemented, must use groups#174

Merged
NullVoxPopuli merged 2 commits intomainfrom
copilot/fix-docs-site-routing
Feb 25, 2026
Merged

Fix docs site: kolay src shorthand is not implemented, must use groups#174
NullVoxPopuli merged 2 commits intomainfrom
copilot/fix-docs-site-routing

Conversation

Copy link
Contributor

Copilot AI commented Feb 24, 2026

The kolay vite plugin's top-level src option is documented as a shorthand but is never consumed by combinedPlugins() — only options.groups is passed through to setup(). As a result, the docs directory was silently ignored and every doc page returned "Page not found".

Changes

  • docs-app/vite.config.js: Replace the ignored src shorthand with the groups array that kolay actually reads. Use name: '' so pages resolve at root-level URLs (e.g. /1-get-started/index.md), matching existing links. import.meta.resolve() produces a file:// URL that kolay's internal normalizePath() converts to an absolute path for correct Vite /@fs imports.
// Before — `src` is silently ignored by combined.js
kolay({
  src: import.meta.resolve('./public/docs', import.meta.url),
  packages: ['@universal-ember/table'],
}),

// After — kolay actually reads options.groups
kolay({
  groups: [{ name: '', src: import.meta.resolve('./public/docs') }],
  packages: ['@universal-ember/table'],
}),

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix routing issue in docs site Fix docs site: kolay src shorthand is not implemented, must use groups Feb 24, 2026
Copilot AI requested a review from NullVoxPopuli February 24, 2026 23:38
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review February 25, 2026 00:24
@NullVoxPopuli NullVoxPopuli merged commit 228d21d into main Feb 25, 2026
13 checks passed
@NullVoxPopuli NullVoxPopuli deleted the copilot/fix-docs-site-routing branch February 25, 2026 00:25
@github-actions github-actions bot mentioned this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants