MCP resolve defs refs #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tibility - Add @apidevtools/json-schema-ref-parser dependency - Implement schema dereferencing in registerManual to resolve $defs and $ref - Resolves issue with FastMCP 2.0+ servers (e.g., basic-memory) - Fixes MissingRefError: can't resolve reference #/$defs/... - Maintains backwards compatibility with legacy MCP servers - All existing tests pass Related to: universal-tool-calling-protocol/code-mode#10
…efs-schema-resolution Fix mcp defs schema resolution
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="bun.lock">
<violation number="1" location="bun.lock:114">
@apidevtools/json-schema-ref-parser requires @types/json-schema as a peer dependency, but @utcp/mcp never declares it, leaving the new dependency in bun.lock with an unmet peer requirement.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| "version": "1.0.12", | ||
| "version": "1.0.16", | ||
| "dependencies": { | ||
| "@apidevtools/json-schema-ref-parser": "^15.1.2", |
Contributor
There was a problem hiding this comment.
@apidevtools/json-schema-ref-parser requires @types/json-schema as a peer dependency, but @utcp/mcp never declares it, leaving the new dependency in bun.lock with an unmet peer requirement.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At bun.lock, line 114:
<comment>@apidevtools/json-schema-ref-parser requires @types/json-schema as a peer dependency, but @utcp/mcp never declares it, leaving the new dependency in bun.lock with an unmet peer requirement.</comment>
<file context>
@@ -109,10 +109,11 @@
- "version": "1.0.12",
+ "version": "1.0.16",
"dependencies": {
+ "@apidevtools/json-schema-ref-parser": "^15.1.2",
"@modelcontextprotocol/sdk": "^1.17.4",
- "@utcp/sdk": "^1.0.4",
</file context>
✅ Addressed in 539efc4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Resolves MCP tool schema compatibility with FastMCP 2.0+ by automatically dereferencing JSON Schema $defs/$ref, preventing MissingRefError during tool discovery. Updates @utcp/mcp to handle schemas transparently.
Bug Fixes
Dependencies
Written for commit 539efc4. Summary will update automatically on new commits.