Skip to content

Conversation

@Rizziepit
Copy link
Contributor

No description provided.

@Rizziepit
Copy link
Contributor Author

@smn @miltontony I'd like to discuss this PR before I carry on. What are your thoughts on implementing the home page for IoGT? I've put the recent, random content logic in the view code, and thus had to override the springboard view. It's using this springboard branch: universalcore/springboard#27.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight concern here about the size of the content list, we should at least flag this with a TODO or a warning.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.95% when pulling 9b2b74c on feature/issue-1-override-springboard-homepage-view into 5d8ff04 on develop.

@Rizziepit
Copy link
Contributor Author

@smn @miltontony ready for review (or re-review). @smn I've changed the IoGTViews.recent_changes method a lot.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>>> filter(None, [None, 1, 2, 3])
[1, 2, 3]

has the same effect.

@smn
Copy link

smn commented May 26, 2015

👍 on the general approach and thanks for going through the effort of not adding caching. Given the client is likely going to still reconsider some of this then I suppose having this stay like this is ok.

@Rizziepit Rizziepit merged commit 01d3321 into develop May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants