-
Notifications
You must be signed in to change notification settings - Fork 0
override springboard homepage view #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
override springboard homepage view #1
Conversation
|
@smn @miltontony I'd like to discuss this PR before I carry on. What are your thoughts on implementing the home page for IoGT? I've put the recent, random content logic in the view code, and thus had to override the springboard view. It's using this springboard branch: universalcore/springboard#27. |
springboard_iogt/views.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight concern here about the size of the content list, we should at least flag this with a TODO or a warning.
|
@smn @miltontony ready for review (or re-review). @smn I've changed the |
springboard_iogt/views.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> filter(None, [None, 1, 2, 3])
[1, 2, 3]has the same effect.
|
👍 on the general approach and thanks for going through the effort of not adding caching. Given the client is likely going to still reconsider some of this then I suppose having this stay like this is ok. |
No description provided.