Skip to content

Conversation

@Rizziepit
Copy link
Contributor

No description provided.

@Rizziepit
Copy link
Contributor Author

@smn @miltontony @nathanbegbie ready for review.

I need to add and override views in a springboard app. So I've split up the existing SpringboardViews class to make a reusable base class. The new structure:

  • springboard.views.base with SpringboardViews base class
  • springboard.views.core with CoreViews for category/pages/etc
  • springboard.views.auth with AuthViews for login/logout

I'm happy to discard this PR if there's a nicer way to do this. But I'd like a way to reuse the context/elastic-git logic.

@Rizziepit
Copy link
Contributor Author

Actually, reusability is just a part of it. I think we should start splitting things up into smaller chunks.

@smn
Copy link
Contributor

smn commented May 22, 2015

Is it not possible to just override the url routing in the generated application.py to another view? Would that be a simpler approach perhaps?

@Rizziepit
Copy link
Contributor Author

Yes, you'd have to override the url routing despite these changes.Have a look at how I'm using this: universalcore/springboard-iogt#1. All I'm doing in this PR is reorganizing code so that there is a base class that view classes can extend. Maybe I'm misunderstanding you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We grew a config_list() function for this in springboard.utils.

@Rizziepit Rizziepit closed this May 25, 2015
@Rizziepit Rizziepit deleted the feature/issue-27-make-view-logic-reusable branch May 25, 2015 11:10
@Rizziepit Rizziepit restored the feature/issue-27-make-view-logic-reusable branch May 25, 2015 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants