Skip to content

Ensure GA titles are set for the views add here #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2015
Merged

Ensure GA titles are set for the views add here #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions springboard_iogt/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,3 +171,45 @@ def test_language_visibility(self):
app = self.mk_app(self.workspace, main=main, settings=settings)
html = app.get('/does/not/exist/', expect_errors=True).html
self.assertFalse(html.find('div', class_='lang'))

@patch('unicore.google.tasks.pageview.delay')
def test_ga_page_titles(self, mock_task):
app = self.mk_app(
self.workspace, main=main,
settings={'ga.profile_id': 'ID-000',
'ga.persona_dimension_id': 'dimension0'})

next_url = 'http://localhost/page/1234/'
querystring = urlencode({'next': next_url})

app.get('/persona/')
data = mock_task.call_args[0][2]
self.assertEqual(data['dt'], 'Choose Persona')

app.get('/persona/worker/?%s' % querystring)
data = mock_task.call_args[0][2]
self.assertEqual(data['dt'], 'Selected Persona')

app.get('/persona/skip/')
data = mock_task.call_args[0][2]
self.assertEqual(data['dt'], 'Skip Persona Selection')

@patch('unicore.google.tasks.pageview.delay')
def test_section_ga_page_title(self, mock_task):
ffl_workspace = self.mk_workspace(name='ffl')
[category] = self.mk_categories(ffl_workspace, count=1, position=1)
[page] = self.mk_pages(
ffl_workspace, count=1, position=1,
created_at=datetime.utcnow().isoformat(),
primary_category=category.uuid)
app = self.mk_app(self.workspace, main=main, settings={
'ga.profile_id': 'ID-000',
'ga.persona_dimension_id': 'dimension0',
'unicore.content_repo_urls': '\n'.join([self.workspace.working_dir,
ffl_workspace.working_dir])
})
app.set_cookie(PERSONA_COOKIE_NAME, PERSONA_SKIP_COOKIE_VALUE)

app.get('/section/ffl/')
data = mock_task.call_args[0][2]
self.assertEqual(data['dt'], 'Facts for Life')
5 changes: 5 additions & 0 deletions springboard_iogt/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

from springboard.views.base import SpringboardViews

from springboard.utils import ga_context
from springboard_iogt.utils import (
get_redirect_url, get_matching_route, update_query, ContentSection)

Expand Down Expand Up @@ -41,11 +42,13 @@ def persona_tween(request):

class IoGTViews(SpringboardViews):

@ga_context(lambda context: {'dt': 'Choose Persona', })
@view_config(route_name='personae',
renderer='springboard_iogt:templates/personae.jinja2')
def personae(self):
return self.context()

@ga_context(lambda context: {'dt': 'Selected Persona', })
@view_config(route_name='select_persona')
def select_persona(self):
slug = self.request.matchdict['slug'].upper()
Expand All @@ -64,6 +67,7 @@ def select_persona(self):

return response

@ga_context(lambda context: {'dt': 'Skip Persona Selection', })
@view_config(route_name='skip_persona_selection')
def skip_persona_selection(self):
# set cookie and redirect
Expand All @@ -73,6 +77,7 @@ def skip_persona_selection(self):
max_age=ONE_YEAR)
return response

@ga_context(lambda context: {'dt': context['section'].title, })
@view_config(route_name='content_section',
renderer='springboard_iogt:templates/content_section.jinja2')
def content_section(self):
Expand Down