Merge pull request #53 from unixorn/clean-more-shellcheck-complaints

Clean more shellcheck complaints

Author: unixorn

bin/git-rebase-authors

@@ -6,10 +6,11 @@
 
 set -e
 
+# shellcheck disable=SC2162,SC2034
 while read action sha other; do
   if [ -n "$action" ]; then
     echo -n "$action "
-    git show $sha --format="%h [%an] %s" -s
+    git show "$sha" --format="%h [%an] %s" -s
   else
     echo
   fi

bin/git-rebase-work-in-progress

@@ -4,4 +4,5 @@
 #
 # Rebase commits that haven't been pushed to the tracked branch
 
-git rebase -i $(git rev-parse --abbrev-ref --symbolic-full-name @{u})
+# shellcheck disable=SC1083
+exec git rebase -i "$(git rev-parse --abbrev-ref --symbolic-full-name @{u})"

bin/git-recently-checkedout-branches

@@ -13,6 +13,7 @@ set -e
 seen=":"
 git_dir="$(git rev-parse --git-dir)"
 
+# shellcheck disable=SC2162
 git reflog -n100 --pretty='%cr|%gs' --grep-reflog='checkout: moving' HEAD | \
   while read line; do
     date="${line%%|*}"

bin/git-rm-deleted-from-repo

@@ -6,4 +6,4 @@
 #
 # Delete files from the repo that you've deleted with `rm` instead of `git rm`
 
-exec git rm $(git ls-files -d)
+exec git rm "$(git ls-files -d)"

bin/git-show-overwritten

@@ -29,7 +29,7 @@ abort() {
 while [ "$#" -gt 0 ]; do
   case "$1" in
   --color ) colorize=1 ;;
-  --no-color ) colorize= ;;
+  --no-color ) colorize='';;
   -h | --help )
     sed -ne '/^#/!q;s/.\{1,2\}//;1d;p' < "$0"
     exit 0
@@ -101,14 +101,16 @@ git diff "${base}...${head}" --diff-filter=DM --no-prefix -w -U0 | grep -v '^+'
   }
   END { print num_lines, name_length }
 ' | sort -n | {
+  # shellcheck disable=SC2162
   read num_lines name_length
   if [ "$num_lines" -eq 0 ]; then
     color 31 "Warning: " >&2
     echo "no changed/removed lines found in the $base...$head diff" >&2
   fi
 
+  # shellcheck disable=SC2162
   while IFS=$'\t' read time sha author msg; do
-    date -r $time "+%Y-%m-%d" | tr -d $'\n'
+    date -r "$time" "+%Y-%m-%d" | tr -d $'\n'
     printf ' '
     color 33 "${sha:0:7}"
     printf '  '

bin/git-switch

@@ -7,5 +7,5 @@
 #
 # Source: https://github.com/Andrew565/dotfiles
 
-BRANCH=`git branch | grep "$1"`
-exec git checkout $BRANCH
+BRANCH=$(git branch | grep "$1")
+exec git checkout "$BRANCH"

bin/git-track

@@ -4,4 +4,4 @@
 # `origin/$branch-name`.
 
 branch=$(git rev-parse --abbrev-ref HEAD)
-git branch $branch --set-upstream-to origin/$branch
+exec git branch "$branch" --set-upstream-to "origin/$branch"