connected_socket(): fix validation check for HAPEE >= 2.1 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command `socket info` returns metadata about the socket connection to a HAProxy process. Since the latest release of HAProxy Enterprise Edition (2.1), the `Name` entry is no longer "HAProxy" but "hapee-lb". This broke our validation check, causing connected_socket() to always return False.
Owner
|
Thanks for the fix. |
Contributor
Author
|
Thank you for the quick response Pavlos! Are you going to make a release? |
Owner
Right now I don't have the capacity, but I will check again during the weekend. Sorry |
Contributor
Author
|
No worries! |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
socket inforeturns metadata about the socketconnection to a HAProxy process. Since the latest release of
HAProxy Enterprise Edition (2.1), the
Nameentry is no longer"HAProxy" but "hapee-lb". This broke our validation check,
causing connected_socket() to always return False.