Skip to content

fix: always call timeEnd after timeLog in createDebugger when inspect is true #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinamra1102 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: always call timeEnd after timeLog in createDebugger when inspect is true #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/debugger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,8 @@ export function createDebugger(
}
if (options.inspect) {
console.timeLog(logPrefix(event), event.args);
} else {
console.timeEnd(logPrefix(event));
}
console.timeEnd(logPrefix(event));
if (options.group) {
console.groupEnd();
}
Expand Down
12 changes: 12 additions & 0 deletions test/debuger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,18 @@ describe("debugger", () => {
await hooks.callHook("other:hook");
expect(console.time).toBeCalled();
});
it("should end timer when inspect is true", async () => {
createDebugger(hooks, { inspect: true });
await hooks.callHook("hook");
expect(console.timeEnd).toBeCalledWith(expect.stringContaining("hook"));
});
it("should not leak timers when calling same hook twice with inspect", async () => {
createDebugger(hooks, { inspect: true });
await hooks.callHook("hook");
await hooks.callHook("hook");
expect(console.time).toBeCalledTimes(2);
expect(console.timeEnd).toBeCalledTimes(2);
});
it("should allowing closing debugger", async () => {
const debug = createDebugger(hooks);
await hooks.callHook("hook");
Expand Down