fix(web-outgoing): handle invalid response header characters#106
Conversation
catch ERR_INVALID_CHAR errors from res.setHeader() when upstream servers return headers with invalid characters (e.g. control chars), instead of crashing the proxy. Invalid headers are silently skipped. ref: http-party/node-http-proxy#1395
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=======================================
Coverage 96.14% 96.15%
=======================================
Files 8 8
Lines 623 624 +1
Branches 233 233
=======================================
+ Hits 599 600 +1
Misses 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
res.setHeader()inwriteHeadersmiddleware with a try/catch to gracefully skip headers containing invalid characters (e.g. control chars like\u0001)ERR_INVALID_CHARwhen upstream servers return malformed headersUpstream ref: http-party/node-http-proxy#1395