fix(ws): skip writing to closed socket on non-upgrade response#114
Merged
Conversation
Check socket.writable before writing the HTTP response when the upstream does not upgrade the connection. Prevents uncatchable "socket has been ended" errors when the client disconnects before the response arrives. Upstream: http-party/node-http-proxy#1552
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 96.14% 97.55% +1.40%
==========================================
Files 8 8
Lines 623 695 +72
Branches 233 279 +46
==========================================
+ Hits 599 678 +79
+ Misses 24 17 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
socket.writablebefore writing the HTTP response when the upstream does not upgrade the WebSocket connectionws-incoming.ts(ProxyServer middleware) andws.ts(standaloneproxyUpgrade)Upstream: http-party/node-http-proxy#1552
Test plan
test/ws.test.ts— verifiessocket.write()is not called when the socket is destroyed before the non-upgrade response