Skip to content

fix(ssl): prevent undefined target values from overwriting ssl options#118

Merged
pi0 merged 1 commit intomainfrom
fix/ssl-options-undefined
Mar 25, 2026
Merged

fix(ssl): prevent undefined target values from overwriting ssl options#118
pi0 merged 1 commit intomainfrom
fix/ssl-options-undefined

Conversation

@pi0
Copy link
Copy Markdown
Member

@pi0 pi0 commented Mar 25, 2026

Summary

  • Port of upstream fix from http-party/node-http-proxy#1504
  • In setupOutgoing, when copying properties (cert, key, ca, pfx, etc.) from the target object to the outgoing request options, undefined values from the target would overwrite existing SSL options passed via options.ssl
  • The fix skips assignment when the target value is undefined, preserving SSL config set on the outgoing object

Test plan

  • Added regression test that fails without the fix and passes with it
  • Full test suite passes (245 tests, 0 failures)

When `setupOutgoing` copies properties like `cert`, `key`, `ca` from the
target object, undefined values would overwrite existing ssl options passed
via `options.ssl`. Skip assignment when the target value is undefined.

Upstream: http-party/node-http-proxy#1504
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

Warning

Rate limit exceeded

@pi0 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 55 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8f1d0d3b-06e1-4b34-b521-aca6e65d0dbb

📥 Commits

Reviewing files that changed from the base of the PR and between f30f90f and 14ee620.

📒 Files selected for processing (2)
  • src/_utils.ts
  • test/_utils.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ssl-options-undefined

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.13%. Comparing base (f30f90f) to head (14ee620).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   96.12%   96.13%           
=======================================
  Files           8        8           
  Lines         645      646    +1     
  Branches      243      244    +1     
=======================================
+ Hits          620      621    +1     
  Misses         24       24           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pi0 pi0 merged commit 9cd99ac into main Mar 25, 2026
7 checks passed
@pi0 pi0 deleted the fix/ssl-options-undefined branch March 25, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant