fix(ssl): prevent undefined target values from overwriting ssl options#118
fix(ssl): prevent undefined target values from overwriting ssl options#118
Conversation
When `setupOutgoing` copies properties like `cert`, `key`, `ca` from the target object, undefined values would overwrite existing ssl options passed via `options.ssl`. Skip assignment when the target value is undefined. Upstream: http-party/node-http-proxy#1504
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 96.12% 96.13%
=======================================
Files 8 8
Lines 645 646 +1
Branches 243 244 +1
=======================================
+ Hits 620 621 +1
Misses 24 24
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
setupOutgoing, when copying properties (cert,key,ca,pfx, etc.) from the target object to the outgoing request options,undefinedvalues from the target would overwrite existing SSL options passed viaoptions.sslundefined, preserving SSL config set on the outgoing objectTest plan