Skip to content

fix(web-outgoing): strip transfer-encoding on 204/304#122

Merged
pi0 merged 1 commit intomainfrom
fix/remove-chunked-204-304
Mar 25, 2026
Merged

fix(web-outgoing): strip transfer-encoding on 204/304#122
pi0 merged 1 commit intomainfrom
fix/remove-chunked-204-304

Conversation

@pi0
Copy link
Copy Markdown
Member

@pi0 pi0 commented Mar 25, 2026

Summary

  • Strip transfer-encoding header on 204 (No Content) and 304 (Not Modified) proxy responses
  • Per RFC 9110, these status codes must not contain a message body, making transfer-encoding invalid
  • Adds regression tests for 204, 304, and a negative test for normal 200 responses

Upstream: http-party/node-http-proxy#1396

Per RFC 9110, 204 and 304 responses must not contain a message body,
so `transfer-encoding` header is meaningless and should be removed.

Upstream: http-party/node-http-proxy#1396
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.47%. Comparing base (f30f90f) to head (3734858).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   96.12%   96.47%   +0.35%     
==========================================
  Files           8        8              
  Lines         645      710      +65     
  Branches      243      289      +46     
==========================================
+ Hits          620      685      +65     
  Misses         24       24              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pi0 pi0 merged commit 743abaa into main Mar 25, 2026
6 checks passed
@pi0 pi0 deleted the fix/remove-chunked-204-304 branch March 25, 2026 20:24
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

Warning

Rate limit exceeded

@pi0 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 2 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 34e53e22-fe21-4fca-8bb3-4e6d900db0e5

📥 Commits

Reviewing files that changed from the base of the PR and between 9cd99ac and 3734858.

📒 Files selected for processing (2)
  • src/middleware/web-outgoing.ts
  • test/middleware/web-outgoing.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-chunked-204-304

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant