fix(web-outgoing): strip transfer-encoding on 204/304#122
Conversation
Per RFC 9110, 204 and 304 responses must not contain a message body, so `transfer-encoding` header is meaningless and should be removed. Upstream: http-party/node-http-proxy#1396
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 96.12% 96.47% +0.35%
==========================================
Files 8 8
Lines 645 710 +65
Branches 243 289 +46
==========================================
+ Hits 620 685 +65
Misses 24 24
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
transfer-encodingheader on 204 (No Content) and 304 (Not Modified) proxy responsestransfer-encodinginvalidUpstream: http-party/node-http-proxy#1396