fix(web-incoming): use isSSL regex for consistent https/wss protocol checks#123
fix(web-incoming): use isSSL regex for consistent https/wss protocol checks#123
isSSL regex for consistent https/wss protocol checks#123Conversation
…l checks Upstream: http-party/node-http-proxy#1419 The forward, target, and redirect code paths used `=== "https:"` which missed `wss:` and other SSL protocol variants. The rest of the codebase already uses the shared `isSSL` regex — align these three call sites.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 96.15% 96.41% +0.25%
==========================================
Files 8 8
Lines 651 698 +47
Branches 245 277 +32
==========================================
+ Hits 626 673 +47
Misses 24 24
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
forward,target, andfollowRedirectscode paths inweb-incoming.tsused=== "https:"to decide betweenhttpandhttpsagentswss:and other SSL protocol variants, causing them to incorrectly use plain HTTP_utils.ts,ws-incoming.ts,ws.ts) already uses the sharedisSSLregex — this aligns the three remaining call sitesTest plan
isSSLusage in_utils.ts:55,_utils.ts:103,ws-incoming.ts:86,ws.ts:143