Skip to content

fix: allow httpStorage allowAllDomains config param to be used.#189

Merged
pi0 merged 1 commit intounjs:mainfrom
Jarrku:patch-1
Nov 9, 2023
Merged

fix: allow httpStorage allowAllDomains config param to be used.#189
pi0 merged 1 commit intounjs:mainfrom
Jarrku:patch-1

Conversation

@Jarrku
Copy link
Copy Markdown
Contributor

@Jarrku Jarrku commented Nov 9, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The allowAllDomains option is documented in the TS types, but currently it not used. Added a change so when the value is passed in, it's also used.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Copy Markdown
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 9, 2023

Codecov Report

Merging #189 (61a0d2c) into main (4828679) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   54.01%   54.05%   +0.04%     
==========================================
  Files          11       11              
  Lines        1083     1084       +1     
  Branches       45       45              
==========================================
+ Hits          585      586       +1     
  Misses        498      498              
Files Coverage Ξ”
src/storage/http.ts 58.33% <100.00%> (+0.38%) ⬆️

@pi0 pi0 merged commit 01227aa into unjs:main Nov 9, 2023
@Jarrku Jarrku deleted the patch-1 branch October 8, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants