Skip to content

Conversation

@mattzamora
Copy link

No description provided.

@colinodell
Copy link
Contributor

I'm on the fence about this change.

On one hand, we probably shouldn't be using @package in our projects anymore. But as you shared IRL, we do have some projects which still have it.

Maybe we could try disabling this sniff for your particular project first?

@mattzamora
Copy link
Author

I do see documentation mentioning @Package is not part of the Symfony standard in particular for PHP. What I really wanted was a way for PHPStorm to not auto-inject @Package when rendering the PHP Comments stub for a class. It was not an option in their Settings interface sadly. However, we did prove that we can ignore @Package sniffs. So I suggest we resolve this issue by closing the merge request and and not implementing any changes.

@colinodell
Copy link
Contributor

What I really wanted was a way for PHPStorm to not auto-inject @Package when rendering the PHP Comments stub for a class.

You should be able to modify the default templates: https://www.jetbrains.com/help/phpstorm/using-file-and-code-templates.html

Closing this as no changes are required to this repo.

@colinodell colinodell closed this Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants