-
Notifications
You must be signed in to change notification settings - Fork 2
Support slevomat/coding-standard 8.x + make PHP 8.1 default #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support slevomat/coding-standard 8.x + make PHP 8.1 default #21
Conversation
Based on doctrine/coding-standard methodology
1101811 to
5992542
Compare
|
Feel free to remove the |
|
@colinodell What do you think of only supporting php 8+? |
|
I think that's fine since 7.4 is EOL and anyone who really needs 7.4 support can still use existing versions of this standard. |
|
Removed the Generic.Formatting.MultipleStatementAlignment. I dont mind but it does cause unnecessary changes sometimes I think this is a good start. At this point, we havent added much php 8 specific rules yet, I think we can add several rules but that can be discussed after an initial slevomat 8.x support release. Please feel free to critique / suggest |
|
Perhaps it would be easier if we make a 4.0.x branch? |
…ltipleStatementAlignment
ff0a5c1 to
9655694
Compare
These are big changes. It is BC breaking and should be a new major release.