Skip to content

Conversation

@jonnyeom
Copy link
Collaborator

@jonnyeom jonnyeom commented Feb 5, 2023

These are big changes. It is BC breaking and should be a new major release.

  • Up selvomat/coding-standard to 8.x
  • Up phpcs version to 3.7.x
  • Remove php 7.x support.
  • Upgrade fixtures with current methodologies of doctrine/coding-standard (for future maintainability)

@jonnyeom jonnyeom force-pushed the feature/slevomat8-support-and-php81-default branch from 1101811 to 5992542 Compare February 5, 2023 01:30
@colinodell
Copy link
Contributor

Feel free to remove the Generic.Formatting.MultipleStatementAlignment sniff too, if you'd like. I kind of hate it now :P Your call though!

@jonnyeom
Copy link
Collaborator Author

jonnyeom commented Feb 8, 2023

@colinodell
This change will make this fail on php 7.4 I realized.

What do you think of only supporting php 8+?

@colinodell
Copy link
Contributor

I think that's fine since 7.4 is EOL and anyone who really needs 7.4 support can still use existing versions of this standard.

@jonnyeom jonnyeom marked this pull request as ready for review February 10, 2023 01:24
@jonnyeom
Copy link
Collaborator Author

jonnyeom commented Feb 10, 2023

Removed the Generic.Formatting.MultipleStatementAlignment. I dont mind but it does cause unnecessary changes sometimes

I think this is a good start.

At this point, we havent added much php 8 specific rules yet, I think we can add several rules but that can be discussed after an initial slevomat 8.x support release.

Please feel free to critique / suggest

@jonnyeom
Copy link
Collaborator Author

Perhaps it would be easier if we make a 4.0.x branch?

@jonnyeom jonnyeom force-pushed the feature/slevomat8-support-and-php81-default branch from ff0a5c1 to 9655694 Compare February 15, 2023 15:00
@jonnyeom jonnyeom changed the base branch from master to 4.0.x February 15, 2023 15:13
@jonnyeom jonnyeom self-assigned this Feb 20, 2023
@jonnyeom jonnyeom merged commit 8479489 into unleashedtech:4.0.x Feb 20, 2023
@jonnyeom jonnyeom deleted the feature/slevomat8-support-and-php81-default branch February 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants