Merged
Conversation
Contributor
UnstoppableMango
commented
Nov 30, 2025
- WIP
- WIP
- Update deps
- That worked I guess
- CI and stuff
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Nix flake support to the devctl project, enabling reproducible builds and development environments through Nix. The changes include dependency updates, test adaptations for Nix environments, and CI integration.
- Adds Nix flake configuration with gomod2nix for Go dependency management
- Updates GitHub Actions CI to include Nix build validation and gomod2nix synchronization checks
- Refactors test suite to work in Nix build environments by replacing git repository detection with manual path construction
Reviewed changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| flake.nix | Defines Nix flake with build configuration, development shell, and multi-platform support |
| flake.lock | Lock file pinning Nix flake input versions |
| gomod2nix.toml | Generated Go module dependency hashes for Nix builds |
| go.mod | Adds gomod2nix as a Go tool and updates unmango/go dependency to v0.10.2 |
| go.sum | Updates checksums for new and updated dependencies |
| test/e2e/e2e_suite_test.go | Replaces git.Root with manual path construction using os.Getwd and filepath.Join |
| pkg/work/work.go | Updates git.Root call to git.RootContext for consistency |
| pkg/work/work_test.go | Changes error assertion from exact match to substring match for compatibility |
| pkg/work/cmd_test.go | Adds gitInit helper function to create temporary git repositories for testing |
| Makefile | Adds Nix-related variables and gomod2nix.toml build target, replaces WORKING_DIR with CURDIR |
| .github/workflows/ci.yml | Adds Nix build job and gomod2nix synchronization check job |
| .gitignore | Excludes Nix-specific artifacts (.direnv/, result) |
| .dprint.json | Excludes gomod2nix.toml from formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.