Skip to content

chore: use new uno sdk samples project #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kazo0 merged 4 commits into from
Apr 10, 2025
Merged

chore: use new uno sdk samples project #1364

kazo0 merged 4 commits into from
Apr 10, 2025

Conversation

@kazo0
Copy link
Contributor

@kazo0 kazo0 commented Mar 21, 2025

No description provided.

@unodevops
Copy link
Contributor

unodevops commented Mar 21, 2025

⚠️⚠️ The build 158238 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Mar 21, 2025

⚠️⚠️ The build 158315 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Mar 21, 2025

⚠️⚠️ The build 158322 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Mar 23, 2025

⚠️⚠️ The build 158388 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Mar 23, 2025

⚠️⚠️ The build 158394 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Mar 23, 2025

⚠️⚠️ The build 158396 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Mar 25, 2025

⚠️⚠️ The build 158512 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Mar 25, 2025

⚠️⚠️ The build 158531 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Apr 2, 2025

⚠️⚠️ The build 159501 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Apr 2, 2025

⚠️⚠️ The build 159547 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Apr 3, 2025

⚠️⚠️ The build 159563 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Apr 3, 2025

⚠️⚠️ The build 159705 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Apr 3, 2025

⚠️⚠️ The build 159729 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Apr 3, 2025

⚠️⚠️ The build 159744 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Apr 4, 2025

⚠️⚠️ The build 159790 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Apr 4, 2025

⚠️⚠️ The build 159814 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Apr 5, 2025

⚠️⚠️ The build 159909 has failed on Uno Toolkit - CI.

@unodevops
Copy link
Contributor

unodevops commented Apr 5, 2025

⚠️⚠️ The build 159950 has failed on Uno Toolkit - CI.

@kazo0 kazo0 force-pushed the dev/sb/sdk-samples branch from 0355a53 to 28bcbae Compare April 6, 2025 03:07
@kazo0 kazo0 marked this pull request as ready for review April 6, 2025 03:08
@kazo0 kazo0 changed the title chore: wip add new sample project chore: use new uno sdk samples project Apr 6, 2025
@unodevops
Copy link
Contributor

unodevops commented Apr 6, 2025

⚠️⚠️ The build 159959 has failed on Uno Toolkit - CI.

@jeromelaban
Copy link
Member

jeromelaban commented Apr 7, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 7, 2025

Azure Pipelines failed to run 1 pipeline(s).

@kazo0
Copy link
Contributor Author

kazo0 commented Apr 7, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 7, 2025

Azure Pipelines failed to run 1 pipeline(s).

@jeromelaban
Copy link
Member

jeromelaban commented Apr 9, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 9, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@kazo0 kazo0 requested a review from Copilot April 9, 2025 13:33
Copilot AI reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 516 out of 523 changed files in this pull request and generated 1 comment.

Files not reviewed (7)
  • build/workflow/build.csproj: Language not supported
  • build/workflow/scripts/android-uitest-run.sh: Language not supported
  • build/workflow/scripts/ios-uitest-build.sh: Language not supported
  • build/workflow/scripts/ios-uitest-run.sh: Language not supported
  • build/workflow/scripts/wasm-uitest-run.sh: Language not supported
  • global.json: Language not supported
  • samples/Directory.Build.props: Language not supported
Comments suppressed due to low confidence (1)

build/workflow/templates/set-app-versions.yml:4

  • Consider whether the binlog file name in the msbuildArguments (set-version-winui-build.binlog) should be updated to reflect the new AppName (Uno.Toolkit.Samples) for consistency.
displayName: Update app versions

@kazo0 kazo0 enabled auto-merge (squash) April 9, 2025 17:22
@kazo0 kazo0 disabled auto-merge April 9, 2025 17:45
@kazo0 kazo0 enabled auto-merge (squash) April 10, 2025 12:15
@kazo0 kazo0 merged commit ad8bc32 into main Apr 10, 2025
19 checks passed
@kazo0 kazo0 deleted the dev/sb/sdk-samples branch April 10, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kazo0 @unodevops @jeromelaban