Skip to content

Conversation

@pujitm
Copy link
Member

@pujitm pujitm commented Nov 21, 2025

@elibosley this is what Codex came up with re: the versioning mismatch for 4.27.1 yesterday

Summary by CodeRabbit

  • Chores
    • Enhanced build workflow with release-aware versioning logic. Version management now automatically adapts based on release status, utilizing release tags when available and maintaining backward compatibility for standard builds.

✏️ Tip: You can customize this high-level summary in your review settings.

@pujitm pujitm requested a review from elibosley November 21, 2025 15:04
@pujitm pujitm marked this pull request as ready for review November 21, 2025 15:04
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR updates the GitHub Actions workflow to calculate API_VERSION based on release metadata. If a release is created with a tag, it uses the trimmed tag value; otherwise, it retains the original behavior of using package.json version or Git SHA.

Changes

Cohort / File(s) Summary
Release-aware API_VERSION calculation
\.github/workflows/build-plugin\.yml
Modified API_VERSION logic to check RELEASE_CREATED and RELEASE_TAG environment variables. When both are set, uses the release tag (with leading 'v' removed) and validates against package.json version. Falls back to original behavior (package.json or Git SHA) when not a release.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Review the conditional logic for correctness: ensure RELEASE_TAG is properly trimmed and the fallback behavior matches the original implementation
  • Verify the warning comparison logic between release tag and package.json version is correct
  • Confirm environment variable export to GITHUB_OUTPUT is properly maintained

Poem

🐰 A workflow so clever, now release-aware,
Trimming the 'v's with utmost care,
Release tags dance with package in view,
Fallback flows work when release is through,
Automation refined, precision laid bare! ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/pkg-versioning

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 375dcd0 and 349aa30.

📒 Files selected for processing (1)
  • .github/workflows/build-plugin.yml (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@elibosley elibosley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a ton of sense.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.04%. Comparing base (375dcd0) to head (349aa30).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1804   +/-   ##
=======================================
  Coverage   52.04%   52.04%           
=======================================
  Files         874      874           
  Lines       50372    50372           
  Branches     5017     5017           
=======================================
  Hits        26214    26214           
  Misses      24083    24083           
  Partials       75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1804/dynamix.unraid.net.plg

@pujitm pujitm merged commit 31af99e into main Nov 21, 2025
12 of 13 checks passed
@pujitm pujitm deleted the fix/pkg-versioning branch November 21, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants